fix: prefer client bearer token over injected basic auth#180
Open
outrider-jkoch wants to merge 1 commit into
Open
fix: prefer client bearer token over injected basic auth#180outrider-jkoch wants to merge 1 commit into
outrider-jkoch wants to merge 1 commit into
Conversation
Registries like quay.io use a two-phase auth flow: the Docker client first exchanges basic credentials for a bearer token, then uses the bearer token for manifest/blob requests.
The old single-map approach unconditionally replaced the client's authorization header with "Basic $dockerAuth" whenever credentials were configured, overwriting the bearer token and causing 401s on content fetches.
The new two-map approach computes what we would inject ($injectedAuth) but only uses it when the client has sent no authorization header at all. If the client has already negotiated auth (bearer or basic), that header is passed through unchanged.
Addresses the upstream @todo comment regarding gcr.io and quay.io auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registries like quay.io use a two-phase auth flow: the Docker client first exchanges basic credentials for a bearer token, then uses the bearer token for manifest/blob requests.
The old single-map approach unconditionally replaced the client's authorization header with "Basic $dockerAuth" whenever credentials were configured, overwriting the bearer token and causing 401s on content fetches.
The new two-map approach computes what we would inject ($injectedAuth) but only uses it when the client has sent no authorization header at all. If the client has already negotiated auth (bearer or basic), that header is passed through unchanged.
Addresses the upstream @todo comment regarding gcr.io and quay.io auth.